Merged
Conversation
ztanner
force-pushed
the
01-27-tweak_lru_sentinel_cache_key
branch
from
48d0289 to
7b90d3e
Compare
ijjk
approved these changes
Jan 27, 2026
ztanner
added a commit
that referenced
this pull request
Jan 27, 2026
We originally prefixed the TTL sentinel with the null-byte separator to avoid collisions with real invocation IDs, but that makes `extractInvocationID` return "ttl" instead of undefined for TTL-mode keys. This switches to a reserved magic string sentinel so TTL-mode entries are correctly treated as “no invocation ID”.
ztanner
added a commit
that referenced
this pull request
Jan 27, 2026
We originally prefixed the TTL sentinel with the null-byte separator to avoid collisions with real invocation IDs, but that makes `extractInvocationID` return "ttl" instead of undefined for TTL-mode keys. This switches to a reserved magic string sentinel so TTL-mode entries are correctly treated as “no invocation ID”.
ztanner
added a commit
that referenced
this pull request
Jan 27, 2026
We originally prefixed the TTL sentinel with the null-byte separator to avoid collisions with real invocation IDs, but that makes `extractInvocationID` return "ttl" instead of undefined for TTL-mode keys. This switches to a reserved magic string sentinel so TTL-mode entries are correctly treated as “no invocation ID”.
ztanner
added a commit
that referenced
this pull request
Jan 28, 2026
We originally prefixed the TTL sentinel with the null-byte separator to avoid collisions with real invocation IDs, but that makes `extractInvocationID` return "ttl" instead of undefined for TTL-mode keys. This switches to a reserved magic string sentinel so TTL-mode entries are correctly treated as “no invocation ID”.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We originally prefixed the TTL sentinel with the null-byte separator to avoid collisions with real invocation IDs, but that makes
extractInvocationIDreturn "ttl" instead of undefined for TTL-mode keys.This switches to a reserved magic string sentinel so TTL-mode entries are correctly treated as “no invocation ID”.