CSS: rename some variables to be consistent

[louismaximepiton]

Description

Rename each -2xl to -xxl.

Motivation & Context

Be consistent with other variables.

Type of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (non-breaking change)
• Breaking change (fix or feature that would change existing functionality)

Checklist

• I have read the contributing guidelines
• My code follows the code style of the project (using npm run lint)
• My change introduces changes to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

Live previews

• https://deploy-preview-37804--twbs-bootstrap.netlify.app/

Related issues

NA

[louismaximepiton]

Is there any way to deprecate those CSS variables ?

[julien-deramond]

Haven't reviewed precisely the PR but I agree with the principle here for consistency through the whole framework.

@twbs/css-review I'm not too familiar with when we authorize to deprecated some Sass vars like this. I'd say that in this case, it would be OK to deprecate them in v5.3 and not wait until v6. But a second opinion would help me :)

Is there any way to deprecate those CSS variables ?

Right now, I believe that only our migration guide do the job

[mdo]

This is an interesting one because one request we had late in v5's development to consider for v6 is that we use 2xl instead of xxl as it might scale better to even larger sizes like 3xl, 4xl, etc. I hate the inconsistency, but maybe we could reassign the old CSS and Sass vars to the new value, and then back track in v6? Thoughts?

[julien-deramond]

consider for v6 is that we use 2xl instead of xxl as it might scale better to even larger sizes like 3xl, 4xl, etc.

Oh yeah nice, it will be better like this indeed.

I hate the inconsistency, but maybe we could reassign the old CSS and Sass vars to the new value, and then back track in v6? Thoughts?

Works for me, sounds like a good strategy

[mdo]

I think these two comments address it?