Skip to content

Change nav focus to focus-visible#37784

Merged
mdo merged 2 commits intomainfrom
nav-focus
Jan 3, 2023
Merged

Change nav focus to focus-visible#37784
mdo merged 2 commits intomainfrom
nav-focus

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented Jan 2, 2023

Fixes #37778.

@julien-deramond @patrickhlauke Is this enough to address this, or do we need to do something else for :focus?

Live preview

https://deploy-preview-37784--twbs-bootstrap.netlify.app/

@mdo mdo requested a review from a team as a code owner January 2, 2023 19:32
@patrickhlauke
Copy link
Copy Markdown
Member

This solves the first part of #37778

First of all, the outline shouldn't be displayed when the focus is given via the mouse; it should remains given by the keyboard. FWIW we removed this kind of behavior from the buttons not a long time ago.

but the contrast is still way too low (particularly in our docs navigation) ... but that part can be sorted separately

@mdo mdo merged commit e30916b into main Jan 3, 2023
@mdo mdo deleted the nav-focus branch January 3, 2023 03:50
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Navbar/Navs now have a focus ring

2 participants