Improve consistency of navbar icon declaration#37720
Merged
Conversation
mdo
approved these changes
Dec 26, 2022
Member
mdo
left a comment
There was a problem hiding this comment.
I had done the separate fill on purpose, but I’m fine having a variable for it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The file
scss/_variables.scssdefines several embedded svg images. The svg definitions use parameterization to support Bootstrap's color system. The declaration of$navbar-light-toggler-icon-bgis inconsistent with the other declarations, as it uses#{rgba($body-color, .75)}instead of referring to a predefined variable.Motivation & Context
This PR introduces a new variable
$navbar-light-icon-colorto improve consistency. The existing variable$navbar-light-coloris kept intact to avoid introducing unwanted side effects.Type of changes
Checklist
npm run lint)Live previews
Related issues
N/A