Fix Android Chrome input date dimensions#36143
Merged
Conversation
tkrotoff
commented
Apr 10, 2022
tkrotoff
commented
Apr 10, 2022
6c8aee4 to
4968592
Compare
234d3d0 to
73c81ec
Compare
73c81ec to
83fdff0
Compare
83fdff0 to
1fefec6
Compare
Contributor
Author
|
Any news? |
1fefec6 to
1b36335
Compare
1b36335 to
ae7bcfe
Compare
Contributor
Author
|
Any news? |
Member
|
Missed this myself. Is the width bug present in any other browser? I don’t have an Android to test myself. |
ae7bcfe to
8ecff17
Compare
Contributor
Author
|
Visual tests js/tests/visual/input.html On macOS Monterey 12.6.2:
On Android 13 (Pixel 4):
On iOS 16.2 (iPhone 14 Pro Max Simulator):
The width problem on Safari iOS is also fixed by this PR: |
c44d271 to
d8e4c4f
Compare
This was referenced Sep 24, 2024
This was referenced Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Under Android Chrome, input date dimensions are broken:
Before 40px high vs 38px for the other inputs:
After 38px high:
I've tested by plugging in my Android device via USB then opened chrome://inspect/#devices (USB debugging must be enabled on the device).
Hence the need for an HTTP server