📝 Update HTTPException details in docs/en/docs/tutorial/handling-errors.md#5418
Merged
tiangolo merged 3 commits intofastapi:masterfrom Jan 15, 2024
Merged
📝 Update HTTPException details in docs/en/docs/tutorial/handling-errors.md#5418tiangolo merged 3 commits intofastapi:masterfrom
HTTPException details in docs/en/docs/tutorial/handling-errors.md#5418tiangolo merged 3 commits intofastapi:masterfrom
Conversation
Update outdated comparison between Starlette's and FastAPI's `HTTPException`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5418 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13934 -35
=========================================
- Hits 13969 13934 -35 ☔ View full report in Codecov by Sentry. |
Contributor
|
📝 Docs preview for commit 1a56230 at: https://632cf15be9447700626b28e6--fastapi.netlify.app |
Contributor
|
📝 Docs preview for commit f2d4477 at: https://639cdc3c04b775009f17a4e4--fastapi.netlify.app |
tiangolo
changed the title
HTTPException details in docs/en/docs/tutorial/handling-errors.md
tiangolo
added
docs
Member
|
Good point about the text update, thanks @papb! 🔍 |
nilslindemann
pushed a commit
to nilslindemann/fastapi
that referenced
this pull request
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates an outdated comparison between Starlette's and FastAPI's
HTTPException.The current docs became outdated when Starlette was upgraded to 0.19.0 which included this change.
In fact, FastAPI's own version of
HTTPExceptionalmost became unnecessary, but @tiangolo caught a little difference regarding a type hint.Related discussion in Starlette: Kludex/starlette#1865