fix(numbers): correctly determine malformed decimals#1042
Merged
akx merged 3 commits intopython-babel:masterfrom Nov 28, 2023
Merged
fix(numbers): correctly determine malformed decimals#1042akx merged 3 commits intopython-babel:masterfrom
akx merged 3 commits intopython-babel:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
+ Coverage 91.43% 91.44% +0.01%
==========================================
Files 26 26
Lines 4436 4444 +8
==========================================
+ Hits 4056 4064 +8
Misses 380 380 ☔ View full report in Codecov by Sentry. |
akx
reviewed
Nov 22, 2023
1e42514 to
725bb57
Compare
Signed-off-by: Olunusi Best <olunusibest@gmail.com>
725bb57 to
8f39f58
Compare
akx
approved these changes
Nov 28, 2023
Member
akx
left a comment
There was a problem hiding this comment.
Thank you! I took the liberty of rebasing this, cleaning up the logic a bit and adding a few more test cases for good measure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
Problem:
The current code was primarily designed for numbers like
3,400.00, where the r-stripped value (3,400.) matches the expectedproper(3,400) +.(3,400.) format. It doesn't work for numbers like3,400.60since3,400.6(the value after r-stripping) is incorrectly perceived as not equal to the expected format, which is theproper(3,400.6) +.(3,400.6.), thereby leading to its erroneous detection as improperly formatted.Solution:
Added a more robust method for stripping trailing zeros, specifically targeting only those zeros that appear after the last non-zero digit following the decimal symbol.