Conversation
| axisHoverFormat: axisHoverFormat, | ||
| descriptionOnlyNumbers: descriptionOnlyNumbers, | ||
| descriptionWithDates: descriptionWithDates | ||
| }; |
There was a problem hiding this comment.
Nice idea to move this into cartesian and export the descriptions separately. I know it's a bit long, but can we put "attributes" in the file name? ie axis_format_attributes.js? Otherwise you'd be tempted to think this file contains actual text formatting functions.
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Very nice implementation. I spent a minute thinking about how this would interact with world calendars - I suspect it's going to just give the gregorian half year, but I think it's also going to give the gregorian quarter, because quarters weren't implemented for world calendars. Doubtful anyone will try to use this that way so I wouldn't do anything about it for now, just something to be aware of in case this ever comes up.
Just one naming question but otherwise this is good to go!
archmoj
changed the title
2 participants
Resolves #5725.
@plotly/plotly_js