in_array type narrowing doesn't seem to be working for list of class constants

[ostrolucky]

Bug report

https://phpstan.org/r/d4829352-8adb-446b-8734-6937beeb15ac

Code snippet that reproduces the problem

No response

Expected output

no errors

Did PHPStan help you today? Did it make you happy in any way?

yup

[ostrolucky]

Hmm, it seems this is the case only when 3rd argument is not true https://phpstan.org/r/a12c07a5-7dc2-4e26-8bde-1f3a5eeee536

[phpstan-bot]

@ostrolucky After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
 
 28: Parameter #1 $level of method LoggerInterface::log() expects 'alert'|'critical'|'debug'|'emergency'|'error'|'info'|'notice'|'warning', string given.
 
-PHP 7.2 – 7.4 (4 errors)
+PHP 7.2 – 7.4 (3 errors)
 ==========
 
 18: Promoted properties are supported only on PHP 8.0 and later.
 28: Parameter #1 $level of method LoggerInterface::log() expects 'alert'|'critical'|'debug'|'emergency'|'error'|'info'|'notice'|'warning', string given.
-37: Method LoggerInterface::log() uses native union types but they're supported only on PHP 8.0 and later.
-37: Parameter $message of method LoggerInterface::log() has invalid type Stringable.
+37: Method LoggerInterface::log() uses native union types but they're supported only on PHP 8.0 and later.

Full report

PHP 8.0 – 8.4 (1 error)

Line	Error
28	`Parameter #1 $level of method LoggerInterface::log() expects 'alert'

PHP 7.2 – 7.4 (3 errors)

Line	Error
18	Promoted properties are supported only on PHP 8.0 and later.
28	`Parameter #1 $level of method LoggerInterface::log() expects 'alert'
37	Method LoggerInterface::log() uses native union types but they're supported only on PHP 8.0 and later.

[phpstan-bot]

@ostrolucky After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
 
 No errors
 
-PHP 7.2 – 7.4 (3 errors)
+PHP 7.2 – 7.4 (2 errors)
 ==========
 
 18: Promoted properties are supported only on PHP 8.0 and later.
-37: Method LoggerInterface::log() uses native union types but they're supported only on PHP 8.0 and later.
-37: Parameter $message of method LoggerInterface::log() has invalid type Stringable.
+37: Method LoggerInterface::log() uses native union types but they're supported only on PHP 8.0 and later.

Full report

PHP 8.0 – 8.4

No errors

PHP 7.2 – 7.4 (2 errors)

Line	Error
18	Promoted properties are supported only on PHP 8.0 and later.
37	Method LoggerInterface::log() uses native union types but they're supported only on PHP 8.0 and later.

[VincentLanglet]

I think we can consider the in_array check as "strict" when the types are the same
phpstan/phpstan-src#3942

[ondrejmirtes]

Fixed phpstan/phpstan-src#3942

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.