Removing Throwable on ContainerExceptionInterface#31
Merged
weierophinney merged 1 commit intophp-fig:1.1from Mar 5, 2021
Merged
Removing Throwable on ContainerExceptionInterface#31weierophinney merged 1 commit intophp-fig:1.1from
weierophinney merged 1 commit intophp-fig:1.1from
Conversation
We added Throwable on ContainerExceptionInterface because we thought this would not introduce any breaking changes. Alas, some classes implementing the ContainerExceptionInterface are already adding the Throwable interface, and PHP won't let us add the interface twice. This problem occurs with PHP 7.2 and PHP 7.3 only.
phansys
approved these changes
Mar 5, 2021
Contributor
Author
|
Note: DO NOT MERGE THIS IN MASTER! (master is the 2.0 branch) |
derrabus
approved these changes
Mar 5, 2021
chalasr
approved these changes
Mar 5, 2021
Contributor
Author
|
Ok, I created a 1.1 branch in the psr/container repository and the PR is now correctly targetting this new 1.1 branch. I'm not sure if we need to delete the branch later or if we keep the branch open for a future 1.1.2 (see #30 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added Throwable on ContainerExceptionInterface because we thought this would not introduce any breaking changes.
Alas, some classes implementing the ContainerExceptionInterface are already adding the Throwable interface,
and PHP won't let us add the interface twice.
This problem occurs with PHP 7.2 and PHP 7.3 only.
See #30