module: allow subpath imports that start with #/

[hybrist]

It's a common ecosystem pattern to map a source root directory to @/ but it requires special tooling support. This turns #/* into a more realistic alternative for that pattern.

See: #49182

[nodejs-github-bot]

Review requested:

• @nodejs/loaders
• @nodejs/typescript

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (6706b22) to head (9f4d8ec).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60864      +/-   ##
==========================================
- Coverage   88.54%   88.51%   -0.04%     
==========================================
  Files         703      703              
  Lines      208262   208393     +131     
  Branches    40170    40198      +28     
==========================================
+ Hits       184408   184454      +46     
- Misses      15861    15928      +67     
- Partials     7993     8011      +18     

Files with missing lines	Coverage Δ
lib/internal/modules/esm/resolve.js	96.19% <100.00%> (-0.01%)	⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Renegade334]

From the perspective of adding support for a new module resolution flavour to TS et al, should this either be semver-major or >=v25.x-only?

[hybrist]

From the perspective of adding support for a new module resolution flavour to TS et al, should this either be semver-major or >=v25.x-only?

Since this only turns a previous import error into a non-error case, this seems safe to backport pretty aggressively. From the TS perspective, I would expect it to show up in the bundler mode eventually? If TS doesn't actively allow it in node20 mode etc. that doesn't seem like a huge issue.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70365/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70366/

[hybrist]

CI is clean. Added a change entry to the docs for subpath imports to track version support for this change.

[GeoffreyBooth]

I think this is fine, but did we dig up the reason for the exclusion in the first place?

[hybrist]

Short answer: no. I did try to look around a bit but I couldn't really find one. The behavior was introduced in the original PR (#34117) and @guybedford's reason seemed to be caution but not necessarily explicit risks:

I thought it seemed sensible to lock down these base cases, but happy to reconsider.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70373/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70376/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70378/

[getify]

@hybrist just curious, has this yet been backported to v24 branch?

[Renegade334]

just curious, has this yet been backported to v24 branch?

It doesn't require backporting, but won't land in v24.x until it's been landed on the active branch for a period first.

[jsumners-nr]

@chrisbbreuer please stop.

[ovflowd]

@nodejs/moderation is there something we can do to stop this spamming of references from this @chrisbbreuer.

[chrisbbreuer]

Thanks for notifying me.

This "chrisbbreuer" will resolve it.

On a different note, we are civilized people @ovflowd. Keep your passive aggressive tone to yourself because this clearly wasn't an intention.

[ovflowd]

Thanks for notifying me.

This "chrisbbreuer" will resolve it.

On a different note, we are civilized people @ovflowd. Keep your passive aggressive tone to yourself because this clearly wasn't an intention.

With all due respect, you spammed 200+ comments on this repository. You have no say here and I couldn't care less about your demands. (Don't invade someone's else's home and start demanding things in a passive aggressive tone yourself)

On a different note, I'm not a native English speaker, the "this" preceding your handle was my attempt of not assuming your pronouns.