Skip to content

sqlite: create authorization api#59928

Closed
araujogui wants to merge 18 commits intonodejs:mainfrom
araujogui:feat/sqlite-authz
Closed

sqlite: create authorization api#59928
araujogui wants to merge 18 commits intonodejs:mainfrom
araujogui:feat/sqlite-authz

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Sep 18, 2025

Fixes #59916

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 18, 2025

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 18, 2025
geeksilva97
geeksilva97 reviewed Sep 18, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (97e55f8) to head (0f4816f).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 88.07% 8 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59928      +/-   ##
==========================================
+ Coverage   88.27%   88.46%   +0.18%     
==========================================
  Files         703      703              
  Lines      207333   207653     +320     
  Branches    39875    40031     +156     
==========================================
+ Hits       183028   183691     +663     
+ Misses      16263    15942     -321     
+ Partials     8042     8020      -22
Files with missing lines Coverage Δ
src/node_sqlite.h 80.39% <ø> (ø)
src/node_sqlite.cc 80.15% <88.07%> (+0.54%) ⬆️

... and 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax
addaleax requested changes Sep 18, 2025
View reviewed changes
addaleax
addaleax approved these changes Sep 23, 2025
View reviewed changes
addaleax
addaleax reviewed Sep 24, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Sep 24, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Sep 25, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Sep 25, 2025
View reviewed changes
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69378/

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69387/

addaleax
addaleax reviewed Sep 26, 2025
View reviewed changes
@araujogui
Copy link
Member Author

araujogui commented Sep 30, 2025

@addaleax @geeksilva97 are we good to merge?

@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69472/

@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 1, 2025
@addaleax
Copy link
Member

addaleax commented Oct 1, 2025

Landed in b217051

addaleax pushed a commit that referenced this pull request Oct 1, 2025
@araujogui @addaleax
sqlite: create authorization api
b217051 
PR-URL: #59928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@addaleax addaleax closed this Oct 1, 2025
@cjihrig cjihrig mentioned this pull request Oct 1, 2025
Closed
targos pushed a commit that referenced this pull request Oct 6, 2025
@araujogui @targos
sqlite: create authorization api
18c79d9 
PR-URL: #59928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Oct 7, 2025
@nodejs-github-bot
2025-10-07, Version 24.10.0 (Current)
6e0ed65 
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
@nodejs-github-bot @RafaelGSS
2025-10-08, Version 24.10.0 (Current)
9b72b88 
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
@nodejs-github-bot @RafaelGSS
2025-10-08, Version 24.10.0 (Current)
642a7c0 
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@github-actions github-actions bot mentioned this pull request Jan 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig left review comments

@Renegade334 Renegade334 Renegade334 left review comments

@geeksilva97 geeksilva97 geeksilva97 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite: expose authorization API

6 participants

@araujogui @nodejs-github-bot @addaleax @cjihrig @Renegade334 @geeksilva97