fix(sse): handle multi-line messages #2643
Merged
+248
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where SSE messages containing newlines in the
datafield would be incorrectly parsed by the client.Per the SSE spec, multi-line data must be sent as multiple
data:lines that the EventSource parser concatenates. Previously, MSW sent the data as a singledata:field, which caused messages containing\n\nto be truncated (since\n\nterminates an SSE message).Before:
data:line1\n\nline2
Client receives:
"line1"(truncated)After:
data:line1
data:
data:line2
Client receives:
"line1\n\nline2"(correct)The fix handles all SSE line terminators per spec: LF (
\n), CR (\r), and CRLF (\r\n).Let me know your thoughts. Thanks!