Rule proposal: no-access-state-in-setstate#1374
Merged
ljharb merged 4 commits intojsx-eslint:masterfrom Nov 3, 2017
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule prevents the use of
this.statewithinthis.setState. It is further described indocs/rules/no-access-state-in-setstate.mdin the PR, but to summarize:this.setStateis async, and referring tothis.statewithin it may lead to race conditions.This is my first eslint-plugin PR, so I am really happy to get any kind of feedback.
edit:
This is also the recommended way doing it in the react docs: