New boolean-prop-naming rule for enforcing the naming of booleans#1264
Merged
lencioni merged 1 commit intojsx-eslint:masterfrom Jun 27, 2017
Merged
New boolean-prop-naming rule for enforcing the naming of booleans#1264lencioni merged 1 commit intojsx-eslint:masterfrom
boolean-prop-naming rule for enforcing the naming of booleans#1264lencioni merged 1 commit intojsx-eslint:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At my workplace, we prefer to name our boolean props as "isSomething" or "hasWhatever". This is an ESLint rule which allows devs to specify a Regex pattern for how they want their boolean props named.
Tested with createReactClass, ES6 components, stateless components and Flowtype.
I support, in the future, this rule can be expanded to support naming rules for ANY props, but that felt like overkill for the time being. Hopefully this rule will be useful as is.