Fixes and impls for Ruby 3.4 specs #8533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also implements RecursiveFunctionEx on Block so that blocks can be passed directly without wrapping.
Also a few more backquotes replaced with single.
Several new unpack specs were failing because they did not raise an error for directives like "a 0A". The problem was that because the handling of the space occurred in the main switch for unpack, it also caused the "0" to be consumed as an unused occurrence count. The unpack then proceeded on to the "A" and returned a result rather than raising. This change matches CRuby by moving the space check all the way to the top of the loop, so that spaces are skipped without any further processing of the next element in the directive.
Most of the logic was already here but there's new bits for non- numeric ranges or ranges stepping with non-numeric values.
Member
Author
|
Merged this after knocking down about 100 failures and getting us well below 100 remaining. The rest will be trickier and probably should be done a PR at a time for each class or method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to whittle down the number of failures in 3.4 specs on JRuby 10.