Update to Shadow 9.x and configure special task#4097
Merged
Conversation
Contributor
Test Results 325 files 325 suites 5m 9s ⏱️ Results for commit 9399d5b. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dondonz
changed the title
Updated the version of the com.gradleup.shadow plugin.
Member
Author
|
I will check after this commit is merged, that our performance pipeline completes successfully |
Member
Author
|
Something's still wrong: the result is an empty list. Revert & will investigate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the major Shadow 9.x update, the fat JMH JAR wasn't correctly created. Found that out when our JMH pipeline failed, our runner couldn't find the main class to start the tests.
Shadow 9.x has many breaking changes, I suspect some of them changed default custom task config behaviour. This PR explicitly sets JMH configuration instead.
Note that you can't "test" this with our unit tests, they are passing but doesn't indicate anything. The real test is if we can run our JMH performance pipeline off this pull request.
I will monitor our perf pipeline after this gets merged in