Conversation
…reate `DataFetcherFactoryEnvironment` objects for simple property fetchers
bbakerman
added
the
performance
bbakerman
commented
Apr 29, 2025
| public DataFetcher<Object> get(GraphQLFieldDefinition fieldDefinition) { | ||
| return SINGLETON_FETCHER; | ||
| } | ||
| }; |
Member
Author
There was a problem hiding this comment.
because I didnt override the default public DataFetcher<Object> get(GraphQLFieldDefinition fieldDefinition) then it returned null and hence it went to the older more heavy weight object and a DataFetcherFactoryEnvironment needed to be allocated.
This now means that no DataFetcherFactoryEnvironment objects are allocated for property fetchers
Member
Author
There was a problem hiding this comment.
I cant unit test this - its not observable - but profiling shows it to be working!
Member
There was a problem hiding this comment.
Nice you could verify via profiling
Contributor
Test Results 312 files 312 suites 53s ⏱️ Results for commit ade6100. |
dondonz
modified the milestones:
24.x non-breaking changes and bugfixes,
25.x breaking changes,
24.0
dondonz
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was always the intention here when we created #3754 to have a singleton property fetcher instance
However we didnt do the factory right and hence
DataFetcherFactoryEnvironmentare created when they dont need to beThis fixes on of the items found in #3939
Namely why was "graphql.schema.DataFetcherFactoryEnvironment" being 2% of objects allocated
This fixes that
re : #3941