Support *.BUILD files #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazel build files for external repos -- eg. used in conjunction with `http_archive` -- are often named <repo>.BUILD
mco-gh
approved these changes
Jun 7, 2023
Contributor
mco-gh
left a comment
mco-gh
left a comment
There was a problem hiding this comment.
thanks for the submission!
Contributor
|
@willnorris Have you seen these lint errors before? Not sure what's triggering them but they seem unrelated to the PR I approved. |
Collaborator
|
oh, weird. No, I've not seen this before. The errors don't even really make sense for the code in addlicense. I just checked, and our config for tailscale is mostly similar: and seems to be running like normal. There are a couple of version differences with the actions/setup-go action and golangci-lint. addlicense isn't pinning to a specific version of the golangci-lint action, so maybe there's an issue with the latest version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel build files for external repos -- eg. used in conjunction with
http_archive-- are often named<repo>.BUILD