Fix #2556 by keeping callback errors from interfering with cleanup#2753
Merged
brianc merged 2 commits intobrianc:masterfrom Jun 20, 2022
Merged
Fix #2556 by keeping callback errors from interfering with cleanup#2753brianc merged 2 commits intobrianc:masterfrom
brianc merged 2 commits intobrianc:masterfrom
Conversation
…rors from interfering with cleanup
Owner
|
Ah yeah this makes sense. Thanks for the PR! I'll get this merged in & released asap. 😄 |
brianc
approved these changes
Jun 20, 2022
Contributor
Author
|
Thanks so much @brianc, I appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brianc and @charmander: This pull request fixes #2556 (and possibly also #1105) by ensuring that errors thrown in user-supplied callbacks do not prevent the node-postgres library from doing necessary cleanup.
This is important for assert-driven testing (such as mocha and jest). Without this fix, one test failure in a
query()callback will create a cascade of subsequent test failures.This implementation should:
nextTick()is already used a few times inclient.jsto defer exception handling)For the repro, see #2556 (comment), and for a description of potential solutions and workarounds, see #2556 (comment).