Skip to content

fix: Stop processing data for logging when logging is disabled and cache response json #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukaszsocha2 merged 3 commits into from
Jul 7, 2023
Merged

fix: Stop processing data for logging when logging is disabled and cache response json #824

lukaszsocha2 merged 3 commits into from
Jul 7, 2023

Conversation

@lukaszsocha2
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 commented Jul 6, 2023

Closes: SDK-3230

@lukaszsocha2 lukaszsocha2 changed the title fix: Do not process data for logging when logging is disabled [WIP] fix: Do not process data for logging when logging is disabled Jul 6, 2023
@coveralls
Copy link

coveralls commented Jul 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5485127018

  • 14 of 15 (93.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.518%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/network/default_network.py 14 15 93.33%
Totals Coverage Status
Change from base Build 5090151024: -0.01%
Covered Lines: 3448
Relevant Lines: 3687
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title [WIP] fix: Do not process data for logging when logging is disabled fix: Do not process data for logging when logging is disabled Jul 6, 2023
@lukaszsocha2 lukaszsocha2 changed the title fix: Do not process data for logging when logging is disabled fix: Stop processing data for logging when logging is disabled and cache response json Jul 7, 2023
mwwoda
mwwoda approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukaszsocha2 lukaszsocha2 merged commit 3079171 into main Jul 7, 2023
@lukaszsocha2 lukaszsocha2 deleted the sdk-3230-fix-network-logging-issue branch July 7, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwwoda mwwoda mwwoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukaszsocha2 @coveralls @mwwoda