Skip to content

fix: Specify which exceptions should be retried #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukaszsocha2 merged 5 commits into from
Dec 29, 2022
Merged

fix: Specify which exceptions should be retried #784

lukaszsocha2 merged 5 commits into from
Dec 29, 2022

Conversation

@lukaszsocha2
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 commented Dec 28, 2022

Closes: SDK-2869

@coveralls
Copy link

coveralls commented Dec 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3801180326

  • 26 of 30 (86.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.485%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/session/session.py 26 30 86.67%
Totals Coverage Status
Change from base Build 3801064858: -0.04%
Covered Lines: 3415
Relevant Lines: 3653
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title feat: Limit retryable exceptions feat: Limit exceptions being retried Dec 28, 2022
@lukaszsocha2 lukaszsocha2 changed the title feat: Limit exceptions being retried fix: Specify which exceptions should be retried Dec 28, 2022
arjankowski
arjankowski previously approved these changes Dec 29, 2022
View reviewed changes
@lukaszsocha2 lukaszsocha2 merged commit 833cd46 into main Dec 29, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-2869-limit-retryable-exceptions branch December 29, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukaszsocha2 @coveralls @arjankowski