fix: Upload session commit return None on 202 #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: SDK-2089 Fixes: #715
Pull Request Test Coverage Report for Build 2033988393
💛 - Coveralls |
kainjow
reviewed
Mar 23, 2022
boxsdk/object/upload_session.py
Outdated
| data=json.dumps(body), | ||
| ) | ||
| except BoxAPIException as box_api_exc: | ||
| if box_api_exc.status == 202: |
Contributor
There was a problem hiding this comment.
could use this from http module:
Suggested change
| if box_api_exc.status == 202: | |
| if box_api_exc.status == HTTPStatus.ACCEPTED: |
lukaszsocha2
force-pushed
the
sdk-2089-upload_session_commit_not_returning_none_on_202
branch
from
d9d2a92 to
e13fa00
Compare
lukaszsocha2
deleted the
sdk-2089-upload_session_commit_not_returning_none_on_202
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: SDK-2089
Fixes: #715