fix(compiler-cli): handle conditional expressions when extracting dependencies#59637
Closed
clydin wants to merge 2 commits intoangular:mainfrom
Closed
fix(compiler-cli): handle conditional expressions when extracting dependencies#59637clydin wants to merge 2 commits intoangular:mainfrom
clydin wants to merge 2 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: compiler
crisbeto
approved these changes
Jan 20, 2025
packages/compiler-cli/src/ngtsc/hmr/src/extract_dependencies.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
hmr/capture-conditional-expressions
branch
from
3acab07 to
9f01987
Compare
clydin
changed the title
AndrewKushnir
added
the
action: cleanup
…endencies Updates the HMR dependencies extraction logic to handle conditional expressions. For example, `providers: [condition ? providersA : providersB]`.
Updates the HMR dependencies extraction logic to handle new expressions. For example, `deps: [[new Optional(), dep]]`.
clydin
force-pushed
the
hmr/capture-conditional-expressions
branch
from
9f01987 to
7f33ee3
Compare
clydin
removed
the
action: cleanup
Contributor
|
This PR was merged into the repository by commit 5a13dff. The changes were merged into the following branches: main, 19.1.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…endencies (angular#59637) Updates the HMR dependencies extraction logic to handle conditional expressions. For example, `providers: [condition ? providersA : providersB]`. PR Close angular#59637
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
angular#59637) Updates the HMR dependencies extraction logic to handle new expressions. For example, `deps: [[new Optional(), dep]]`. PR Close angular#59637
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the HMR dependencies extraction logic to handle conditional expressions. For example,
providers: [condition ? providersA : providersB].Closes #59634