fix(compiler): avoid having to duplicate core environment#58444
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
fix(compiler): avoid having to duplicate core environment#58444crisbeto wants to merge 2 commits intoangular:mainfrom
crisbeto wants to merge 2 commits intoangular:mainfrom
Conversation
Switches to referencing the core environment directly in the generated code, instead of having to duplicate it.
crisbeto
added
action: review
angular-robot
bot
added
area: compiler
The `ExternalReference.runtime` field wasn't being used anywhere.
angular-robot
bot
added
area: compiler
AndrewKushnir
approved these changes
Oct 31, 2024
AndrewKushnir
removed
the
action: review
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 1, 2024
Switches to referencing the core environment directly in the generated code, instead of having to duplicate it. PR Close #58444
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 1, 2024
The `ExternalReference.runtime` field wasn't being used anywhere. PR Close #58444
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 1, 2024
The `ExternalReference.runtime` field wasn't being used anywhere. PR Close #58444
Contributor
|
This PR was merged into the repository by commit 5ca48e8. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to referencing the core environment directly in the generated code, instead of having to duplicate it.