fix(migrations): properly migrate output aliases#58411
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): properly migrate output aliases#58411pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
the
area: migrations
pkozlowski-opensource
added
action: review
devversion
approved these changes
Oct 29, 2024
pkozlowski-opensource
added
action: merge
Member
|
This PR was merged into the repository by commit 3161360. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix the output migration was incorrectly assuming that the @output decorator takes its params as an object. What happens in reality is that the @output decorator is taking alias as the only argument, without any object literal wrapper.