Conversation
jww3
approved these changes
Jan 8, 2025
yacaovsnc
force-pushed
the
yacaovsnc/artifact_upload_concurrency_and_timeout
branch
from
5119304 to
7e3aa62
Compare
yacaovsnc
changed the title
paveliak
reviewed
Jan 8, 2025
yacaovsnc
force-pushed
the
yacaovsnc/artifact_upload_concurrency_and_timeout
branch
from
7e3aa62 to
ede05b9
Compare
robherley
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make both upload concurrency and timeout settings configurable with env variables.
Concurrency setting can only be lowered with the env variable, the goal is not to increase performance, but to stabilize the upload process.