ci: use deployment: false for integration test environments#712
ci: use deployment: false for integration test environments#712
Conversation
|
Hello from actions/github-script! (07a8b16) |
There was a problem hiding this comment.
Pull request overview
Updates the integration workflow to mark the debug-integration-test environment usage as non-deployment, aiming to reduce noisy deployment records while still applying environment protections/secrets.
Changes:
- Switches the
test-debugjob’senvironmentfrom a string to an object withname. - Adds
deployment: falseto suppress deployment records for the environment reference.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/integration.yml | Adjusts the test-debug job’s environment configuration to use deployment: false. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| environment: | ||
| name: ${{ matrix.environment }} | ||
| deployment: false |
There was a problem hiding this comment.
matrix.environment includes an empty string, but the new object form always sets environment.name. If matrix.environment resolves to '', this can yield an empty environment name and cause the workflow to error (and/or attempt to reference a non-existent environment). Consider conditionally omitting environment when the matrix value is empty (e.g., make environment itself an expression that returns '' for the non-debug case, or restructure the matrix to use a boolean and only set the environment for the debug variant).
| environment: | |
| name: ${{ matrix.environment }} | |
| deployment: false | |
| environment: ${{ matrix.environment && fromJSON(format('{{"name":"{0}","deployment":false}}', matrix.environment)) || '' }} |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://github.com/actions/github-script) | action | major | `v8.0.0` → `v9.0.0` | --- ### Release Notes <details> <summary>actions/github-script (actions/github-script)</summary> ### [`v9.0.0`](https://github.com/actions/github-script/releases/tag/v9.0.0) [Compare Source](actions/github-script@v8.0.0...v9.0.0) **New features:** - **`getOctokit` factory function** — Available directly in the script context. Create additional authenticated Octokit clients with different tokens for multi-token workflows, GitHub App tokens, and cross-org access. See [Creating additional clients with `getOctokit`](https://github.com/actions/github-script#creating-additional-clients-with-getoctokit) for details and examples. - **Orchestration ID in user-agent** — The `ACTIONS_ORCHESTRATION_ID` environment variable is automatically appended to the user-agent string for request tracing. **Breaking changes:** - **`require('@​actions/github')` no longer works in scripts.** The upgrade to `@actions/github` v9 (ESM-only) means `require('@​actions/github')` will fail at runtime. If you previously used patterns like `const { getOctokit } = require('@​actions/github')` to create secondary clients, use the new injected `getOctokit` function instead — it's available directly in the script context with no imports needed. - `getOctokit` is now an injected function parameter. Scripts that declare `const getOctokit = ...` or `let getOctokit = ...` will get a `SyntaxError` because JavaScript does not allow `const`/`let` redeclaration of function parameters. Use the injected `getOctokit` directly, or use `var getOctokit = ...` if you need to redeclare it. - If your script accesses other `@actions/github` internals beyond the standard `github`/`octokit` client, you may need to update those references for v9 compatibility. #### What's Changed - Add ACTIONS\_ORCHESTRATION\_ID to user-agent string by [@​Copilot](https://github.com/Copilot) in [#​695](actions/github-script#695) - ci: use deployment: false for integration test environments by [@​salmanmkc](https://github.com/salmanmkc) in [#​712](actions/github-script#712) - feat!: add getOctokit to script context, upgrade [@​actions/github](https://github.com/actions/github) v9, [@​octokit/core](https://github.com/octokit/core) v7, and related packages by [@​salmanmkc](https://github.com/salmanmkc) in [#​700](actions/github-script#700) #### New Contributors - [@​Copilot](https://github.com/Copilot) made their first contribution in [#​695](actions/github-script#695) **Full Changelog**: <actions/github-script@v8.0.0...v9.0.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMTAuMTIiLCJ1cGRhdGVkSW5WZXIiOiI0My4xMTAuMTMiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://codeberg.org/umati/Sample-Server/pulls/1678 Co-authored-by: umati-bot <git-bot@umati.org> Co-committed-by: umati-bot <git-bot@umati.org>
Uses
deployment: falseon the debug integration test environment reference to suppress deployment records from cluttering PR timelines.The
debug-integration-testenvironment is only used to setrunner.debug = true— no actual deployment is involved. Addingdeployment: falsekeeps access to environment secrets and protection rules while preventing unnecessary deployment objects and webhook noise.