Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Oct 7, 2025


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler force-pushed the g/20251008/min-gradle branch from 8280650 to 1223de6 Compare October 7, 2025 16:50
@Goooler Goooler marked this pull request as draft October 7, 2025 16:51
@Goooler Goooler force-pushed the g/20251008/min-gradle branch from 1223de6 to 79f57da Compare October 7, 2025 16:57
@Goooler Goooler changed the title Bump min Gradle requirement to 9.0 Bump min Gradle requirement to 9.0.0 Oct 7, 2025
@Goooler Goooler force-pushed the g/20251008/min-gradle branch from 79f57da to ae0299d Compare October 7, 2025 17:07
@Goooler Goooler marked this pull request as ready for review October 9, 2025 03:51
@Goooler Goooler mentioned this pull request Oct 9, 2025
@Goooler Goooler force-pushed the g/20251008/min-gradle branch 2 times, most recently from f6720cc to f5305cb Compare October 9, 2025 03:55
@Goooler Goooler requested a review from Copilot October 9, 2025 03:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the minimum Gradle requirement from 8.11 to 9.0.0 for the Shadow plugin version 9.3.0+.

  • Bumped minimum Gradle version requirement to 9.0.0 in documentation and CI configuration
  • Updated string interpolation syntax in test files to use dollar-dollar syntax ($$) required by newer Gradle versions
  • Simplified CI matrix by removing Java 24 exclusion that was specific to older Gradle versions

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/README.md Added new row for version 9.3.0+ with Gradle 9.0 minimum requirement
README.md Added new row for version 9.3.0+ with Gradle 9.0 minimum requirement
.github/workflows/build.yml Updated CI matrix to use Gradle 9.0.0 as minimum and removed Java 24 exclusion
src/test/kotlin/.../SimpleRelocatorTest.kt Updated string interpolation syntax from \$ to $$ for Gradle compatibility
src/functionalTest/kotlin/.../JavaPluginsTest.kt Updated string interpolation syntax from \$ to $$ for Gradle compatibility
src/functionalTest/kotlin/.../ApplicationPluginTest.kt Updated string interpolation syntax from \$ to $$ for Gradle compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Goooler Goooler force-pushed the g/20251008/min-gradle branch from f5305cb to 0dd7319 Compare October 9, 2025 04:01
@Goooler Goooler enabled auto-merge (squash) October 9, 2025 04:08
@Goooler Goooler merged commit 3e44233 into main Oct 9, 2025
11 checks passed
@Goooler Goooler deleted the g/20251008/min-gradle branch October 9, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants