Remove ShadowSpec and reduce overloads
#1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/20250801/remove-shadow-spec
branch
from
7a1b47e to
0fe7634
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ShadowSpec interface and reduces method overloads in the Shadow Gradle plugin by consolidating the API into the ShadowJar class directly. The refactoring simplifies the codebase by eliminating the interface abstraction layer while maintaining the same functionality through default parameters and @JvmOverloads annotation.
- Removes the
ShadowSpecinterface entirely - Converts multiple method overloads into single methods with default parameters using
@JvmOverloads - Updates API signatures to reflect the consolidated approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ShadowSpec.kt | Removes the entire interface file containing method definitions for shadow operations |
| ShadowJar.kt | Consolidates methods from ShadowSpec into ShadowJar with default parameters and @jvmoverloads |
| README.md | Documents the breaking change in the changelog |
| shadow.api | Updates API signatures to reflect removal of ShadowSpec interface and new method signatures |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.