Skip to content

Commit 94c6b62

Browse files
Merge pull request #72 from zoltantothcom/dev
Minor content and style changes
2 parents f73629b + dabaa4b commit 94c6b62

File tree

10 files changed

+31
-16
lines changed

10 files changed

+31
-16
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Design Patterns - a quick game to test your familiarity with the 'Gang of Four' design patterns implemented in JS.
66

7-
### :zap: [PLAY HERE](http://designpatternsgame.com/)
7+
### :zap: [PLAY HERE](https://designpatternsgame.com/)
88

99
![Design Patterns - game results screenshot](/static/screenshot.png?sanitize=true&raw=true)
1010

__tests__/components/__snapshots__/Header.test.js.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ exports[`<Header /> component renders with DARK theme 1`] = `
5353
}
5454
5555
.c8 {
56-
font: 400 0.925rem 'Karla',sans-serif;
56+
font: 400 0.875rem 'Karla',sans-serif;
5757
color: #C8C8C8;
5858
margin: 0.75rem 0 0;
5959
}
@@ -226,7 +226,7 @@ exports[`<Header /> component renders with DARK theme 1`] = `
226226
<h2
227227
className="c8"
228228
>
229-
implemented in JavaScript
229+
“Gang of Four” patterns in JavaScript
230230
</h2>
231231
</div>
232232
</header>
@@ -286,7 +286,7 @@ exports[`<Header /> component renders with LIGHT theme 1`] = `
286286
}
287287
288288
.c8 {
289-
font: 400 0.925rem 'Karla',sans-serif;
289+
font: 400 0.875rem 'Karla',sans-serif;
290290
color: #6F256F;
291291
margin: 0.75rem 0 0;
292292
}
@@ -459,7 +459,7 @@ exports[`<Header /> component renders with LIGHT theme 1`] = `
459459
<h2
460460
className="c8"
461461
>
462-
implemented in JavaScript
462+
“Gang of Four” patterns in JavaScript
463463
</h2>
464464
</div>
465465
</header>

__tests__/components/__snapshots__/PatternsList.test.js.snap

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ exports[`REFERENCE - Patterns List renders all the patterns 1`] = `
1616
margin-top: 2.5rem;
1717
}
1818
19+
.c0 h3 {
20+
border-bottom: 1px solid;
21+
padding-bottom: 1rem;
22+
}
23+
1924
<div
2025
className="c0"
2126
>

__tests__/components/__snapshots__/Title.test.js.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ exports[`<Title /> component renders with a DARK theme 1`] = `
1818
}
1919
2020
.c2 {
21-
font: 400 0.925rem 'Karla',sans-serif;
21+
font: 400 0.875rem 'Karla',sans-serif;
2222
color: #C8C8C8;
2323
margin: 0.75rem 0 0;
2424
}
@@ -34,7 +34,7 @@ exports[`<Title /> component renders with a DARK theme 1`] = `
3434
<h2
3535
className="c2"
3636
>
37-
implemented in JavaScript
37+
“Gang of Four” patterns in JavaScript
3838
</h2>
3939
</div>
4040
`;
@@ -57,7 +57,7 @@ exports[`<Title /> component renders with a LIGHT theme 1`] = `
5757
}
5858
5959
.c2 {
60-
font: 400 0.925rem 'Karla',sans-serif;
60+
font: 400 0.875rem 'Karla',sans-serif;
6161
color: #6F256F;
6262
margin: 0.75rem 0 0;
6363
}
@@ -73,7 +73,7 @@ exports[`<Title /> component renders with a LIGHT theme 1`] = `
7373
<h2
7474
className="c2"
7575
>
76-
implemented in JavaScript
76+
“Gang of Four” patterns in JavaScript
7777
</h2>
7878
</div>
7979
`;

__tests__/pages/__snapshots__/About.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ exports[`About page renders with a DARK theme 1`] = `
1616
}
1717
1818
.c1 {
19-
color: #888888;
19+
color: #F5F5F5;
2020
margin-top: 2rem;
2121
}
2222

__tests__/pages/__snapshots__/Patterns.test.js.snap

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ exports[`Patterns page renders the Patterns list 1`] = `
1616
margin-top: 2.5rem;
1717
}
1818
19+
.c0 h3 {
20+
border-bottom: 1px solid;
21+
padding-bottom: 1rem;
22+
}
23+
1924
<div
2025
className="c0"
2126
>

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
2-
"name": "javascript-patterns",
3-
"version": "0.1.0",
4-
"private": true,
2+
"name": "design-patterns-game",
3+
"version": "1.0.0",
54
"dependencies": {
65
"prop-types": "^15.7.2",
76
"react": "^16.8.6",

src/components/PatternsList.jsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ const StyledPatterns = styled.div`
2121
color: ${props => props.theme.header};
2222
margin-top: 2.5rem;
2323
}
24+
25+
h3 {
26+
border-bottom: 1px solid ${props => props.theme.text};
27+
color: ${props => props.theme.header};
28+
padding-bottom: 1rem;
29+
}
2430
`;
2531

2632
const PatternsList = () => {

src/components/Title.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ const Heading = styled.h1`
1818
`;
1919

2020
const SubHeading = styled.h2`
21-
font: 400 0.925rem 'Karla', sans-serif;
21+
font: 400 0.875rem 'Karla', sans-serif;
2222
color: ${props => props.theme.link};
2323
margin: 0.75rem 0 0;
2424
`;
2525

2626
export const Title = () => (
2727
<TitleContainer>
2828
<Heading>Design Patterns Game</Heading>
29-
<SubHeading>implemented in JavaScript</SubHeading>
29+
<SubHeading>&ldquo;Gang of Four&rdquo; patterns in JavaScript</SubHeading>
3030
</TitleContainer>
3131
);
3232

src/styles/themes/theme.dark.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const themeDark = {
3636
toggleActiveBorder: C.SILVER,
3737

3838
// text and header
39-
header: C.GRAY,
39+
header: C.WILD_SAND,
4040
text: C.SILVER,
4141

4242
border: C.TUNDORA

0 commit comments

Comments
 (0)