Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-kit/kit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ynodir/kit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 27, 2021

  1. Addresses issue #525: 

    Every `With()` call was returning a new instance which wouldn't work unless every `With()` call is reassigned back to original variable - specifically, calls to `Value()` and `ValueReset()` would be returning original instance's (the one created with `NewCounter()`) values.
Reworked it to return the same instance but with updated `lvs` field.
    @c-nyuldashev
    c-nyuldashev committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    1d33acf View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Reworked generic.Counter code to account for multiple dimensions vi… 

    …a `lvs`.

Heavily inspired by @travissalascox PR #570.
    @c-nyuldashev
    c-nyuldashev committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    fd5d32d View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'go-kit:master' into issue-525/fix-generic-counter-with

    @ynodir
    ynodir authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    bea0ca7 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from ynodir/issue-525/fix-generic-counter-with 

    Issue 525/fix generic counter with
    @ynodir
    ynodir authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    0ac87d9 View commit details
    Browse the repository at this point in the history
Loading