Apply some minor cleanup (warnings and undefined behavior) (paceholder#92)

* Surpessed warnings for unused parameters (-Wunused-parameter) in NodeDataModel

* Initialized som former uninitialized members

* Q_OBJECT macro removed, as it is already in base class

* explicitly deleted copy constructor and assignment operator for classes with pointer members

* Revert "Q_OBJECT macro removed, as it is already in base class"

This reverts commit 7aaa2b8.

* removed unnecessary breaks after return statements

* replaced default branch of switch case with explicit enum value

* hack to silence warning, this needs some proper handling

* Update NodeDataModel.hpp

Author: schumacb

examples/connection_colors/models.hpp

@@ -83,8 +83,8 @@ class NaiveDataModel : public NodeDataModel
 
       case PortType::Out:
         result = 2;
-
-      default:
+        break;
+      case PortType::None:
         break;
     }
 
@@ -102,11 +102,8 @@ class NaiveDataModel : public NodeDataModel
         {
           case 0:
             return MyNodeData().type();
-            break;
-
           case 1:
             return SimpleNodeData().type();
-            break;
         }
         break;
 
@@ -115,17 +112,16 @@ class NaiveDataModel : public NodeDataModel
         {
           case 0:
             return MyNodeData().type();
-            break;
-
           case 1:
             return SimpleNodeData().type();
-            break;
         }
         break;
 
-      default:
+      case PortType::None:
         break;
     }
+    // FIXME: control may reach end of non-void function [-Wreturn-type]
+    return NodeDataType();
   }
 
   std::shared_ptr<NodeData>

src/Connection.hpp

@@ -58,6 +58,9 @@ class Connection
              Node& nodeOut,
              PortIndex portIndexOut);
 
+  Connection(const Connection&) = delete;
+  Connection operator=(const Connection&) = delete;
+
   ~Connection();
 
 public:

src/ConnectionState.hpp

@@ -23,6 +23,9 @@ class ConnectionState
     : _requiredPort(port)
   {}
 
+  ConnectionState(const ConnectionState&) = delete;
+  ConnectionState operator=(const ConnectionState&) = delete;
+
   ~ConnectionState();
 
 public:
@@ -55,6 +58,6 @@ class ConnectionState
 
   PortType _requiredPort;
 
-  Node* _lastHoveredNode = nullptr;
+  Node* _lastHoveredNode{nullptr};
 };
 }

src/DataModelRegistry.hpp

@@ -26,9 +26,9 @@ class NODE_EDITOR_PUBLIC DataModelRegistry
 
   struct TypeConverterItem
   {
-    RegistryItemPtr Model;
-    NodeDataType    SourceType;
-    NodeDataType    DestinationType;
+    RegistryItemPtr Model{};
+    NodeDataType    SourceType{};
+    NodeDataType    DestinationType{};
   };
 
   using ConvertingTypesPair = std::pair<QString, QString>; //Source type ID, Destination type ID in this order
@@ -112,9 +112,9 @@ class NODE_EDITOR_PUBLIC DataModelRegistry
 
 private:
 
-  RegisteredModelsCategoryMap _registeredModelsCategory;
-  CategoriesSet _categories;
-  RegisteredModelsMap _registeredModels;
-  RegisteredTypeConvertersMap _registeredTypeConverters;
+  RegisteredModelsCategoryMap _registeredModelsCategory{};
+  CategoriesSet _categories{};
+  RegisteredModelsMap _registeredModels{};
+  RegisteredTypeConvertersMap _registeredTypeConverters{};
 };
 }

src/FlowView.hpp

@@ -16,6 +16,9 @@ class NODE_EDITOR_PUBLIC FlowView
 
   FlowView(FlowScene *scene);
 
+  FlowView(const FlowView&) = delete;
+  FlowView operator=(const FlowView&) = delete;
+
   QAction* clearSelectionAction() const;
 
   QAction* deleteSelectionAction() const;

src/NodeDataModel.hpp

@@ -47,11 +47,11 @@ class NODE_EDITOR_PUBLIC NodeDataModel
 
   /// Port caption is used in GUI to label individual ports
   virtual QString
-  portCaption(PortType portType, PortIndex portIndex) const { return QString(""); }
+  portCaption(PortType, PortIndex) const { return QString(); }
 
   /// It is possible to hide port caption in GUI
   virtual bool
-  portCaptionVisible(PortType portType, PortIndex portIndex) const { return false; }
+  portCaptionVisible(PortType, PortIndex) const { return false; }
 
   /// Name makes this model unique
   virtual QString