Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aspnet/samples
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: yamachu/aspnet-samples
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: react-blazor-component
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 4, 2021

  1. Reactのコード生成だけを見たいので、一旦Angularに関するTaskはコメントアウトする

    @yamachu
    yamachu committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    4ee7537 View commit details
    Browse the repository at this point in the history

  2. OutputPath には bin/Debug/net6.0 みたいな値が渡ってきていて、JSComponentGeneration.Bu… 

    …ild のビルドディレクトリを見ておらず、JSファイルがコピーできていないので、明示的にそのパスを渡すようにする
    @yamachu
    yamachu committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    7d5763e View commit details
    Browse the repository at this point in the history

  3. どこからのPATHかわからなかったのでコメント入れておく

    @yamachu
    yamachu committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    ebda7eb View commit details
    Browse the repository at this point in the history

  4. 自動生成ファイルをそのまま使うことは少なそうなので、generatedみたいなディレクトリに突っ込んで、そこからいい感じにPickする形にする

    @yamachu
    yamachu committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    01d2137 View commit details
    Browse the repository at this point in the history

  5. <template />という記述をしていて、jsxという拡張子の方が妥当であるために変更

    @yamachu
    yamachu committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    54a3398 View commit details
    Browse the repository at this point in the history
Loading