Skip to content

Commit d5fdd10

Browse files
patrickhlaukeadampagembgower
authored
Tweak language around modal dialogs (#4381)
Closes #4185 Note that this only softens/expands some of the example language in the understanding documents. The original issue #4185 seems to conflate non-normative examples in a non-normative document with requirements of how modal dialogs should be implemented ... they are not. They provide examples of appropriate focus order and absence of keyboard traps. They are not the only ways in which focus order or absence of keyboard traps can be achieved. Examples are non-exhaustive, and there is no need - in my view - to expand these further to specifically address variations that result from different behaviours related to `<dialog>` --------- Co-authored-by: Adam Page <adam@adampage.net> Co-authored-by: Mike Gower <mikegower@gmail.com>
1 parent 99b3405 commit d5fdd10

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

understanding/20/focus-order.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,17 +124,19 @@ <h2>Examples of Focus Order</h2>
124124
key expands a node, then using the down arrow key moves into the newly expanded nodes.
125125
</li>
126126

127-
<li>A web page implements modeless dialogs via scripting. When the trigger button is activated,
127+
<li>A web page implements modeless dialogs. When the trigger button is activated,
128128
a dialog opens. The interactive elements in the dialog are inserted in the focus order
129129
immediately after the button. When the dialog is open, the focus order goes from the
130130
button to the elements of the dialog, then to the interactive element following the
131131
button. When the dialog is closed, the focus order goes from the button to the following
132132
element.
133133
</li>
134134

135-
<li>A web page implements modal dialogs via scripting. When the trigger button is activated,
135+
<li>A web page implements modal dialogs. When the trigger button is activated,
136136
a dialog opens and focus is set within the dialog. As
137-
long as the dialog is open, focus is limited to the elements of the dialog. When the
137+
long as the dialog is open, all web page content outside the dialog becomes
138+
inert and cannot receive focus (though, depending on implementation, the focus cycle
139+
might still include user agent controls). When the
138140
dialog is dismissed, focus returns to the button or the element following the button.
139141
</li>
140142

understanding/20/no-keyboard-trap.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,10 @@ <h2>Examples of No Keyboard Trap</h2>
6464
prior to the applet as well as within the applet itself.</dd>
6565
<dt>A modal dialog box</dt>
6666
<dd>A web application brings up a dialog box. At the bottom of the dialog are two buttons,
67-
Cancel and OK. When the dialog has been opened, focus is trapped within the dialog;
68-
tabbing from the last control in the dialog takes focus to the first control in the
69-
dialog. The dialog is dismissed by activating the Cancel button or the OK button.</dd>
67+
Cancel and OK. When the dialog has been opened, all web page content outside the dialog becomes
68+
inert and cannot receive focus (though, depending on implementation, the focus cycle
69+
might still include user agent controls).
70+
The dialog is dismissed by activating the Cancel button or the OK button.</dd>
7071
</dl>
7172

7273
</section>

0 commit comments

Comments
 (0)