Added more flexible support for custom icons via url#151
Added more flexible support for custom icons via url#151oucil wants to merge 1 commit intoswisnl:masterfrom
Conversation
- first, in either case "icon" class is applied - second step, checks for valid URL (uses regex from "jQuery Validation Plugin") - for valid URL an inline style is added using "background-image" - for class name, previous behaviour is preserved (default)
|
Thank you for your PR. I won't merge this one, though… In Issue #129 I already stated that I'd prefer an |
|
Thanks for considering it :) Wouldn't this still allow an My reasoning was, I was looking all over your documentation for ways to supply different icons and there isn't anything obvious that didn't involve a lot of work since we have a LOT of icons and unfortunately no use of sprites yet. I think a lot of users would be in the same position as us, looking for a simple built-in and easily implemented method rather than requiring a lot of extra coding around the edges. In the end, up to you of course, I just think this makes it more accessible to a larger and potentially less skilled audience. Cheers! |
|
You're right, maybe we can merge the two ideas. |
Plugin")