Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubycas/rubycas-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: su-docker/rubycas-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 0 files changed
  • 1 contributor

Commits on Nov 22, 2012

  1. Accessing the ActiveRecord session store only if it is the configured… 

    … session store during single sign out

When anyother session store (ActionDispatch::Session::CookieStore) is used by the Rails app, the single sign out POST request sent by the CAS server ends up in the following exception
'ActiveRecord::StatementInvalid (PG::Error: ERROR:  relation "sessions" does not exist'
Which is correct because there will not be any sessions table if ActiveRecord::SessionStore is not used
    @su-docker
    su-docker committed Nov 22, 2012
    Configuration menu
    Copy the full SHA
    1e10fb1 View commit details
    Browse the repository at this point in the history

  2. Accessing the ActiveRecord session store only if it is the configured… 

    … session store during single sign out

When any other session store (ActionDispatch::Session::CookieStore) is used by the Rails app, the single sign out POST request sent by the CAS server ends up in the following exception
'ActiveRecord::StatementInvalid (PG::Error: ERROR:  relation "sessions" does not exist'
Which is correct because there will not be any sessions table if ActiveRecord::SessionStore is not used
    @su-docker
    su-docker committed Nov 22, 2012
    Configuration menu
    Copy the full SHA
    300aef9 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2012

  1. Reverting the changes to see if the build failure is because of the c… 

    …hanges
    @su-docker
    su-docker committed Nov 23, 2012
    Configuration menu
    Copy the full SHA
    bd3d808 View commit details
    Browse the repository at this point in the history
Loading