Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thesamet/webilder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: stemd/webilder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 6 files changed
  • 1 contributor

Commits on Oct 23, 2012

  1. If session is gnome-session-fallback (Gnome3 imitating Gnome2), varia…

    …ble use will be equal to gnome
    
    (what is logical), but Gnome2 way of changing wallpaper will not work, so adding Gnome3 way.
    stemd committed Oct 23, 2012
    Configuration menu
    Copy the full SHA
    1082664 View commit details
    Browse the repository at this point in the history
  2. If really Gnome2, silently fail.

    stemd committed Oct 23, 2012
    Configuration menu
    Copy the full SHA
    9ecf337 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2012

  1. Added option in menu for seeing name and path of current wallpaper.

    TODO: On restart, name and path are not known as this depends on DE,
    it would be nice to write function also for it, eventually.
    stemd committed Oct 25, 2012
    Configuration menu
    Copy the full SHA
    f3da4db View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2012

  1. Two problems solved:

    current wallpaper on start/boot (it's been read from config file)
    current wallpaper when changed using browser
    
    I was stuck for a while (an hour or two) thinking to store title and path
    of wallpaper in memory or on disk, cause both approaches have its pros & cons:
    I don't like storing on disk things which can be without problems stored in
    memory, that approach reminds me too much of Windows registry,
    but here I found comment that browser can stand as standalone app, and to add
    in it some object passing would disrupt that elegance.
    
    Solution was obvious when I realized that config.py already writes on every
    wallpaper change counter stats to config.py, and as difference in writing
    5 or 6 bytes and 30 or 40 bytes to disk means absolutely nothing (data is
    written in blocks, long time ago smalles block was 512 bytes), so config
    file now stores title and path of current wallpaper.
    
    I had thoughts to store all info, but why to store something that you do not
    use? Only thing that I'm still thinking of is URL, but that depends what
    you want to do with information you have about current wallpaper.
    
    If you want to send pic to somebody, path is enough, and sendto email app
    opener could be handy, if you want to send only URL, that can be done by
    email or some IM. For now, title and path are enough. This is longest
    commit comment I've ever written. :)
    stemd committed Oct 26, 2012
    Configuration menu
    Copy the full SHA
    6fce437 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2012

  1. gnome-session[]: EggSMClient-WARNING: Desktop file

    '/usr/local/share/gnome/autostart/webilder_indicator.desktop' has malformed
    Icon key 'camera48.png'(should not include extension)
    stemd committed Oct 27, 2012
    Configuration menu
    Copy the full SHA
    2634dbb View commit details
    Browse the repository at this point in the history
Loading