Skip to content

Commit 4bfba7a

Browse files
BrentOzarBrentOzar
authored
Merge pull request BrentOzarULTD#306 from BrentOzarULTD/issue-305
BrentOzarULTD#305 - sp_BlitzCache ##bou_BlitzCacheResults not filtered by sessionid
2 parents 929b6bd + 9140bce commit 4bfba7a

File tree

1 file changed

+41
-28
lines changed

1 file changed

+41
-28
lines changed

‎sp_BlitzCache.sql‎

Lines changed: 41 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ Changes in v3.0 - 2016/06/18:
208208
-FIX: @IgnoreQueryHashes was not working. Should be working now.
209209
- Fixed ##bou_BlitzCacheResults not cleaned out after each pass. More info:
210210
https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/303
211+
- Fixed ##bou_BlitzCacheResults not filtered by session id. More info:
212+
https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/305
211213
212214
Changes in v2.5.3 - 2016-04-28:
213215
- Erik Darling added warnings for Expensive Sorts, Key Lookups, Remote Queries.
@@ -759,7 +761,8 @@ IF LEFT(@QueryFilter, 3) NOT IN ('all', 'sta', 'pro')
759761
IF @Reanalyze = 1 AND OBJECT_ID('tempdb..##bou_BlitzCacheResults') IS NULL
760762
SET @Reanalyze = 0;
761763
ELSE IF @Reanalyze = 0
762-
TRUNCATE TABLE ##bou_BlitzCacheResults;
764+
DELETE ##bou_BlitzCacheResults
765+
WHERE SPID = @@SPID;
763766

764767
if @SkipAnalysis = 1
765768
SET @HideSummary = 1;
@@ -2241,7 +2244,6 @@ SET @sql += N' OPTION (RECOMPILE) ; '
22412244

22422245
EXEC sp_executesql @sql, N'@Top INT, @spid INT', @Top, @@SPID ;
22432246

2244-
22452247
IF @HideSummary = 0 AND @ExportToExcel = 0
22462248
BEGIN
22472249
IF @Reanalyze = 0
@@ -2251,7 +2253,8 @@ BEGIN
22512253
/* Build summary data */
22522254
IF EXISTS (SELECT 1/0
22532255
FROM ##bou_BlitzCacheProcs
2254-
WHERE frequent_execution =1)
2256+
WHERE frequent_execution =1
2257+
AND SPID = @@SPID)
22552258
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
22562259
VALUES (@@SPID,
22572260
1,
@@ -2266,7 +2269,7 @@ BEGIN
22662269
IF EXISTS (SELECT 1/0
22672270
FROM ##bou_BlitzCacheProcs
22682271
WHERE parameter_sniffing = 1
2269-
)
2272+
AND SPID = @@SPID)
22702273
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
22712274
VALUES (@@SPID,
22722275
2,
@@ -2280,7 +2283,7 @@ BEGIN
22802283
IF EXISTS (SELECT 1/0
22812284
FROM ##bou_BlitzCacheProcs
22822285
WHERE is_forced_plan = 1
2283-
)
2286+
AND SPID = @@SPID)
22842287
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
22852288
VALUES (@@SPID,
22862289
3,
@@ -2294,7 +2297,7 @@ BEGIN
22942297
IF EXISTS (SELECT 1/0
22952298
FROM ##bou_BlitzCacheProcs
22962299
WHERE is_cursor = 1
2297-
)
2300+
AND SPID = @@SPID)
22982301
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
22992302
VALUES (@@SPID,
23002303
4,
@@ -2307,7 +2310,7 @@ BEGIN
23072310
IF EXISTS (SELECT 1/0
23082311
FROM ##bou_BlitzCacheProcs
23092312
WHERE is_forced_parameterized = 1
2310-
)
2313+
AND SPID = @@SPID)
23112314
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23122315
VALUES (@@SPID,
23132316
5,
@@ -2320,7 +2323,7 @@ BEGIN
23202323
IF EXISTS (SELECT 1/0
23212324
FROM ##bou_BlitzCacheProcs p
23222325
WHERE p.is_parallel = 1
2323-
)
2326+
AND SPID = @@SPID)
23242327
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23252328
VALUES (@@SPID,
23262329
6,
@@ -2333,7 +2336,7 @@ BEGIN
23332336
IF EXISTS (SELECT 1/0
23342337
FROM ##bou_BlitzCacheProcs p
23352338
WHERE near_parallel = 1
2336-
)
2339+
AND SPID = @@SPID)
23372340
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23382341
VALUES (@@SPID,
23392342
7,
@@ -2346,7 +2349,7 @@ BEGIN
23462349
IF EXISTS (SELECT 1/0
23472350
FROM ##bou_BlitzCacheProcs p
23482351
WHERE plan_warnings = 1
2349-
)
2352+
AND SPID = @@SPID)
23502353
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23512354
VALUES (@@SPID,
23522355
8,
@@ -2359,7 +2362,7 @@ BEGIN
23592362
IF EXISTS (SELECT 1/0
23602363
FROM ##bou_BlitzCacheProcs p
23612364
WHERE long_running = 1
2362-
)
2365+
AND SPID = @@SPID)
23632366
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23642367
VALUES (@@SPID,
23652368
9,
@@ -2373,7 +2376,8 @@ BEGIN
23732376

23742377
IF EXISTS (SELECT 1/0
23752378
FROM ##bou_BlitzCacheProcs p
2376-
WHERE p.missing_index_count > 0)
2379+
WHERE p.missing_index_count > 0
2380+
AND SPID = @@SPID)
23772381
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23782382
VALUES (@@SPID,
23792383
10,
@@ -2386,7 +2390,7 @@ BEGIN
23862390
IF EXISTS (SELECT 1/0
23872391
FROM ##bou_BlitzCacheProcs p
23882392
WHERE p.downlevel_estimator = 1
2389-
)
2393+
AND SPID = @@SPID)
23902394
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
23912395
VALUES (@@SPID,
23922396
13,
@@ -2399,7 +2403,7 @@ BEGIN
23992403
IF EXISTS (SELECT 1/0
24002404
FROM ##bou_BlitzCacheProcs p
24012405
WHERE implicit_conversions = 1
2402-
)
2406+
AND SPID = @@SPID)
24032407
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24042408
VALUES (@@SPID,
24052409
14,
@@ -2412,7 +2416,7 @@ BEGIN
24122416
IF EXISTS (SELECT 1/0
24132417
FROM ##bou_BlitzCacheProcs
24142418
WHERE tempdb_spill = 1
2415-
)
2419+
AND SPID = @@SPID)
24162420
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24172421
VALUES (@@SPID,
24182422
15,
@@ -2424,7 +2428,8 @@ BEGIN
24242428

24252429
IF EXISTS (SELECT 1/0
24262430
FROM ##bou_BlitzCacheProcs
2427-
WHERE busy_loops = 1)
2431+
WHERE busy_loops = 1
2432+
AND SPID = @@SPID)
24282433
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24292434
VALUES (@@SPID,
24302435
16,
@@ -2436,7 +2441,8 @@ BEGIN
24362441

24372442
IF EXISTS (SELECT 1/0
24382443
FROM ##bou_BlitzCacheProcs
2439-
WHERE tvf_join = 1)
2444+
WHERE tvf_join = 1
2445+
AND SPID = @@SPID)
24402446
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24412447
VALUES (@@SPID,
24422448
17,
@@ -2448,7 +2454,8 @@ BEGIN
24482454

24492455
IF EXISTS (SELECT 1/0
24502456
FROM ##bou_BlitzCacheProcs
2451-
WHERE compile_timeout = 1)
2457+
WHERE compile_timeout = 1
2458+
AND SPID = @@SPID)
24522459
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24532460
VALUES (@@SPID,
24542461
18,
@@ -2460,7 +2467,8 @@ BEGIN
24602467

24612468
IF EXISTS (SELECT 1/0
24622469
FROM ##bou_BlitzCacheProcs
2463-
WHERE compile_memory_limit_exceeded = 1)
2470+
WHERE compile_memory_limit_exceeded = 1
2471+
AND SPID = @@SPID)
24642472
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24652473
VALUES (@@SPID,
24662474
19,
@@ -2472,7 +2480,8 @@ BEGIN
24722480

24732481
IF EXISTS (SELECT 1/0
24742482
FROM ##bou_BlitzCacheProcs
2475-
WHERE warning_no_join_predicate = 1)
2483+
WHERE warning_no_join_predicate = 1
2484+
AND SPID = @@SPID)
24762485
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24772486
VALUES (@@SPID,
24782487
20,
@@ -2484,7 +2493,8 @@ BEGIN
24842493

24852494
IF EXISTS (SELECT 1/0
24862495
FROM ##bou_BlitzCacheProcs
2487-
WHERE plan_multiple_plans = 1)
2496+
WHERE plan_multiple_plans = 1
2497+
AND SPID = @@SPID)
24882498
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
24892499
VALUES (@@SPID,
24902500
21,
@@ -2496,7 +2506,8 @@ BEGIN
24962506

24972507
IF EXISTS (SELECT 1/0
24982508
FROM ##bou_BlitzCacheProcs
2499-
WHERE unmatched_index_count > 0)
2509+
WHERE unmatched_index_count > 0
2510+
AND SPID = @@SPID)
25002511
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25012512
VALUES (@@SPID,
25022513
22,
@@ -2508,7 +2519,8 @@ BEGIN
25082519

25092520
IF EXISTS (SELECT 1/0
25102521
FROM ##bou_BlitzCacheProcs
2511-
WHERE unparameterized_query = 1)
2522+
WHERE unparameterized_query = 1
2523+
AND SPID = @@SPID)
25122524
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25132525
VALUES (@@SPID,
25142526
23,
@@ -2520,7 +2532,8 @@ BEGIN
25202532

25212533
IF EXISTS (SELECT 1/0
25222534
FROM ##bou_BlitzCacheProcs
2523-
WHERE is_trivial = 1)
2535+
WHERE is_trivial = 1
2536+
AND SPID = @@SPID)
25242537
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25252538
VALUES (@@SPID,
25262539
24,
@@ -2533,7 +2546,7 @@ BEGIN
25332546
IF EXISTS (SELECT 1/0
25342547
FROM ##bou_BlitzCacheProcs p
25352548
WHERE p.is_forced_serial= 1
2536-
)
2549+
AND SPID = @@SPID)
25372550
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25382551
VALUES (@@SPID,
25392552
25,
@@ -2546,7 +2559,7 @@ BEGIN
25462559
IF EXISTS (SELECT 1/0
25472560
FROM ##bou_BlitzCacheProcs p
25482561
WHERE p.is_key_lookup_expensive= 1
2549-
)
2562+
AND SPID = @@SPID)
25502563
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25512564
VALUES (@@SPID,
25522565
26,
@@ -2559,7 +2572,7 @@ BEGIN
25592572
IF EXISTS (SELECT 1/0
25602573
FROM ##bou_BlitzCacheProcs p
25612574
WHERE p.is_sort_expensive= 1
2562-
)
2575+
AND SPID = @@SPID)
25632576
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25642577
VALUES (@@SPID,
25652578
27,
@@ -2572,7 +2585,7 @@ BEGIN
25722585
IF EXISTS (SELECT 1/0
25732586
FROM ##bou_BlitzCacheProcs p
25742587
WHERE p.is_remote_query_expensive= 1
2575-
)
2588+
AND SPID = @@SPID)
25762589
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
25772590
VALUES (@@SPID,
25782591
28,

0 commit comments

Comments
 (0)