Commit 25f4e1d
committed
Fix flaky timezone test fixture
As documented in [RunningTests], tests have to be written to be
independent of any php.ini file.
Without specifying the timezone, the var_dump() will make use of the
default timezone that may not be the expected "UTC" timezone.
This renders the test-cases flaky and will make them fail if the
`date.timezone` is different from the string "UTC".
Fix is to interpolate the timezone in the test fixture or to set
`date.timezone` to `UTC`.
[RunningTests]: docs/source/miscellaneous/running-tests.rst1 parent 23248c2 commit 25f4e1d
File tree
2 files changed
+4
-2
lines changed- Zend/tests/inheritance
- ext/date/tests
2 files changed
+4
-2
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments