Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 8 commits
- 3 files changed
- 1 contributor
Commits on Oct 26, 2025
-
-
fix(asm): fix buffer overflows in operand and get_bytes functions
- Replace variable-length arrays with fixed-size buffers (256 bytes) - Add bounds checks in operand() to prevent buffer overflow - Fix loop condition in get_bytes() to avoid infinite loops - Use safe string copy with strncpy and null termination - Add output buffer size checks before writing - Correct typo in CONSTANT_VALUE_TOO_BIG error
-
fix(asm): add checks for memory allocation failures
- Check return values of malloc, realloc, and strdup in add_label, add_proc, and add_macro - Free allocated memory on strdup failure to prevent leaks - Set appropriate error codes on allocation failures
-
fix(asm): fix expression parsing issues
- Add division by zero checks in exp6() for / and % operators - Replace variable-length arrays with fixed-size buffers in operand, find_opcode_in_string, and find_register_in_string - Add bounds checks to prevent buffer overflows in string parsing functions - In operand(), error on unresolved labels in pass 2 instead of silently returning 0
-
fix(asm): fix file handling issues
- Add check for argc >= 2 in main() to prevent invalid argv[1] access - Change fseek check to error and exit if rewinding file fails for pass 2 - Remove invalid 'else' clause in main() that was causing compilation errors
-
fix(asm): resolve potential bugs in assembler
- Correct SKIP_TOKEN macro logic error - Fix memory leaks in add_macro function - Make label and proc lookups case-insensitive
-
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...code_review