Skip to content

Conversation

@TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jan 13, 2023

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit for your consideration for later releases.

Also maybe you want to merge @JonoYang 's branch in #114 here so we can ensure everything is green there too?

"headers": {
"tool_name": "python-inspector",
"tool_homepageurl": "https://github.com/nexB/python-inspector",
"tool_version": "0.9.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove header information from test files with a function like we do in scancode-toolkit, this will avoid unnecessary churn every time we update. Also gets rid of file paths when --requirement option is specified. Don't have to do this here of course, maybe in a later version.

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit f2b19f9 into main Jan 16, 2023
@TG1999 TG1999 deleted the release/v0.9.4 branch February 6, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants