Address AppleClang compiler warnings

Author: paceholder

CMakeLists.txt

@@ -184,6 +184,7 @@ target_compile_options(QtNodes
   PRIVATE
     $<$<CXX_COMPILER_ID:MSVC>:/W4 /wd4127 /EHsc>
     $<$<CXX_COMPILER_ID:GNU>:-Wall -Wextra>
+    $<$<CXX_COMPILER_ID:AppleClang>:-Wall -Wextra -Werror>
 )
 if(NOT "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
   # Clang-Cl on MSVC identifies as "Clang" but behaves more like MSVC:

include/QtNodes/internal/AbstractGraphModel.hpp

@@ -91,7 +91,7 @@ class NODE_EDITOR_PUBLIC AbstractGraphModel : public QObject
   /// Defines if detaching the connection is possible.
   virtual
   bool
-  detachPossible(ConnectionId const connectionId) const { return true; }
+  detachPossible(ConnectionId const) const { return true; }
 
   /// Creates a new connection between two nodes.
   /**

src/DefaultHorizontalNodeGeometry.cpp

@@ -1,7 +1,6 @@
 #include "DefaultHorizontalNodeGeometry.hpp"
 
 #include "AbstractGraphModel.hpp"
-#include "StyleCollection.hpp"
 #include "NodeData.hpp"
 
 #include <QRect>
@@ -79,8 +78,6 @@ portPosition(NodeId const    nodeId,
              PortType const  portType,
              PortIndex const portIndex) const
 {
-  auto const& nodeStyle = StyleCollection::nodeStyle();
-
   unsigned int const step = _portSize + _portSpasing;
 
   QPointF result;
@@ -99,7 +96,6 @@ portPosition(NodeId const    nodeId,
   {
     case PortType::In:
     {
-      //double x = 0.0 - nodeStyle.ConnectionPointDiameter;
       double x = 0.0;
 
       result = QPointF(x, totalHeight);
@@ -108,7 +104,6 @@ portPosition(NodeId const    nodeId,
 
     case PortType::Out:
     {
-      //double x = size.width() + nodeStyle.ConnectionPointDiameter;
       double x = size.width();
 
       result = QPointF(x, totalHeight);

src/DefaultNodePainter.cpp

@@ -22,9 +22,8 @@ DefaultNodePainter::
 paint(QPainter * painter,
       NodeGraphicsObject & ngo) const
 {
-  AbstractNodeGeometry & geometry = ngo.nodeScene()->nodeGeometry();
-
   // TODO?
+  //AbstractNodeGeometry & geometry = ngo.nodeScene()->nodeGeometry();
   //geometry.recomputeSizeIfFontChanged(painter->font());
 
   drawNodeRect(painter, ngo);

src/DefaultVerticalNodeGeometry.cpp

@@ -1,7 +1,6 @@
 #include "DefaultVerticalNodeGeometry.hpp"
 
 #include "AbstractGraphModel.hpp"
-#include "StyleCollection.hpp"
 #include "NodeData.hpp"
 
 #include <QRect>
@@ -91,10 +90,6 @@ portPosition(NodeId const    nodeId,
              PortType const  portType,
              PortIndex const portIndex) const
 {
-  auto const& nodeStyle = StyleCollection::nodeStyle();
-
-  unsigned int outPortWidth = maxPortsTextAdvance(nodeId, PortType::Out);
-
   QPointF result;
 
   QSize size = _graphModel.nodeData<QSize>(nodeId, NodeRole::Size);

src/NodeDelegateModel.cpp

@@ -46,6 +46,8 @@ portConnectionPolicy(PortType portType, PortIndex) const
     case PortType::Out:
       result = ConnectionPolicy::Many;
       break;
+    case PortType::None:
+      break;
   }
 
   return result;