Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sphinx-doc/sphinx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: marv/sphinx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on May 3, 2015

  1. i18n: Open PO files using UTF-8 encoding 

    This fixes the tests

 test_catalogs.test_compile_all_catalogs
 test_catalogs.test_compile_update_catalogs

which would fail before when dealing with a po file containing non-ASCII
characters with the following error:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
255: ordinal not in range(128)
    @marv
    marv committed May 3, 2015
    Configuration menu
    Copy the full SHA
    0f3cfac View commit details
    Browse the repository at this point in the history

  2. tests: Open files using UTF-8 encoding 

    As in the rest of the testsuite, open files using UTF-8
encoding. Otherwise there would be many errors like the
following:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position
12041: ordinal not in range(128)
    @marv
    marv committed May 3, 2015
    Configuration menu
    Copy the full SHA
    34ee878 View commit details
    Browse the repository at this point in the history

  3. i18n: Use open from codecs module

    @marv
    marv committed May 3, 2015
    Configuration menu
    Copy the full SHA
    814b849 View commit details
    Browse the repository at this point in the history
Loading