Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: launchbadge/sqlx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: marcbowes/sqlx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 13 files changed
  • 1 contributor

Commits on May 2, 2025

  1. sqlx-postgres, sqlx-aws: impl dynamic passwords 

    This commit extends PgConnectOptions to support dynamic passwords, while
maintaining the API and memory layout of the previous (static-only)
implementation.

`PgConnectOptions::password` now takes anything that can be turned into
a `PasswordOption`, which has support for providers. Providers have a
single `fn password(&self)`.

I've chosen to implement the `PasswordProvider` trait as a sync
function, because there are usage paths (like
`ConnectionOptions::to_url_lossy`) that are not `async`. This decision
means that providers that need to do async IO need to do so internally,
such as by spawning a task.

I've included a provider for AWS Aurora DSQL as part of this commit, to
show how a more complex provider can be implemented. I was originally
thinking of publishing this crate separately (outside the sqlx tree),
but it might make sense to keep it in-tree.
    @marcbowes
    marcbowes committed May 2, 2025
    Configuration menu
    Copy the full SHA
    7f7e013 View commit details
    Browse the repository at this point in the history
Loading