Fix multi instance debounce issue

Hatlen · Hatlen · commit a39c0dddf214 · 2016-10-06T08:44:11.000+02:00
The debounce function is shared between the instances so that can create
issues where Codemirror instances doesn't update because the check
function was debounced until it was run for another instance.
diff --git a/dist/react-codemirror.js b/dist/react-codemirror.js
@@ -9449,6 +9449,9 @@ var CodeMirror = React.createClass({
 			isFocused: false
 		};
 	},
+	componentWillMount: function componentWillMount() {
+		this.componentWillReceiveProps = debounce(this.componentWillReceiveProps, 0);
+	},
 	componentDidMount: function componentDidMount() {
 		var textareaNode = findDOMNode(this.refs.textarea);
 		var codeMirrorInstance = this.getCodeMirrorInstance();
@@ -9465,7 +9468,7 @@ var CodeMirror = React.createClass({
 			this.codeMirror.toTextArea();
 		}
 	},
-	componentWillReceiveProps: debounce(function (nextProps) {
+	componentWillReceiveProps: function componentWillReceiveProps(nextProps) {
 		if (this.codeMirror && nextProps.value !== undefined && this.codeMirror.getValue() !== nextProps.value) {
 			this.codeMirror.setValue(nextProps.value);
 		}
@@ -9476,7 +9479,7 @@ var CodeMirror = React.createClass({
 				}
 			}
 		}
-	}, 0),
+	},
 	getCodeMirror: function getCodeMirror() {
 		return this.codeMirror;
 	},
diff --git a/dist/react-codemirror.min.js b/dist/react-codemirror.min.js
diff --git a/lib/Codemirror.js b/lib/Codemirror.js
@@ -28,6 +28,9 @@ var CodeMirror = React.createClass({
 			isFocused: false
 		};
 	},
+	componentWillMount: function componentWillMount() {
+		this.componentWillReceiveProps = debounce(this.componentWillReceiveProps, 0);
+	},
 	componentDidMount: function componentDidMount() {
 		var textareaNode = findDOMNode(this.refs.textarea);
 		var codeMirrorInstance = this.getCodeMirrorInstance();
@@ -44,7 +47,7 @@ var CodeMirror = React.createClass({
 			this.codeMirror.toTextArea();
 		}
 	},
-	componentWillReceiveProps: debounce(function (nextProps) {
+	componentWillReceiveProps: function componentWillReceiveProps(nextProps) {
 		if (this.codeMirror && nextProps.value !== undefined && this.codeMirror.getValue() !== nextProps.value) {
 			this.codeMirror.setValue(nextProps.value);
 		}
@@ -55,7 +58,7 @@ var CodeMirror = React.createClass({
 				}
 			}
 		}
-	}, 0),
+	},
 	getCodeMirror: function getCodeMirror() {
 		return this.codeMirror;
 	},
diff --git a/src/Codemirror.js b/src/Codemirror.js
@@ -24,6 +24,9 @@ const CodeMirror = React.createClass({
 			isFocused: false,
 		};
 	},
+	componentWillMount () {
+		this.componentWillReceiveProps = debounce(this.componentWillReceiveProps, 0);
+	},
 	componentDidMount () {
 		const textareaNode = findDOMNode(this.refs.textarea);
 		const codeMirrorInstance = this.getCodeMirrorInstance();
@@ -40,7 +43,7 @@ const CodeMirror = React.createClass({
 			this.codeMirror.toTextArea();
 		}
 	},
-	componentWillReceiveProps: debounce(function (nextProps) {
+	componentWillReceiveProps: function (nextProps) {
 		if (this.codeMirror && nextProps.value !== undefined && this.codeMirror.getValue() !== nextProps.value) {
 			this.codeMirror.setValue(nextProps.value);
 		}
@@ -51,7 +54,7 @@ const CodeMirror = React.createClass({
 				}
 			}
 		}
-	}, 0),
+	},
 	getCodeMirror () {
 		return this.codeMirror;
 	},

Original file line number	Diff line number	Diff line change
`@@ -9449,6 +9449,9 @@ var CodeMirror = React.createClass({`
`9449`	`9449`	`isFocused: false`
`9450`	`9450`	`};`
`9451`	`9451`	`},`
	`9452`	`+ componentWillMount: function componentWillMount() {`
	`9453`	`+ this.componentWillReceiveProps = debounce(this.componentWillReceiveProps, 0);`
	`9454`	`+ },`
`9452`	`9455`	`componentDidMount: function componentDidMount() {`
`9453`	`9456`	`var textareaNode = findDOMNode(this.refs.textarea);`
`9454`	`9457`	`var codeMirrorInstance = this.getCodeMirrorInstance();`
`@@ -9465,7 +9468,7 @@ var CodeMirror = React.createClass({`
`9465`	`9468`	`this.codeMirror.toTextArea();`
`9466`	`9469`	`}`
`9467`	`9470`	`},`
`9468`		`- componentWillReceiveProps: debounce(function (nextProps) {`
	`9471`	`+ componentWillReceiveProps: function componentWillReceiveProps(nextProps) {`
`9469`	`9472`	`if (this.codeMirror && nextProps.value !== undefined && this.codeMirror.getValue() !== nextProps.value) {`
`9470`	`9473`	`this.codeMirror.setValue(nextProps.value);`
`9471`	`9474`	`}`
`@@ -9476,7 +9479,7 @@ var CodeMirror = React.createClass({`
`9476`	`9479`	`}`
`9477`	`9480`	`}`
`9478`	`9481`	`}`
`9479`		`- }, 0),`
	`9482`	`+ },`
`9480`	`9483`	`getCodeMirror: function getCodeMirror() {`
`9481`	`9484`	`return this.codeMirror;`
`9482`	`9485`	`},`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ var CodeMirror = React.createClass({`
`28`	`28`	`isFocused: false`
`29`	`29`	`};`
`30`	`30`	`},`
	`31`	`+ componentWillMount: function componentWillMount() {`
	`32`	`+ this.componentWillReceiveProps = debounce(this.componentWillReceiveProps, 0);`
	`33`	`+ },`
`31`	`34`	`componentDidMount: function componentDidMount() {`
`32`	`35`	`var textareaNode = findDOMNode(this.refs.textarea);`
`33`	`36`	`var codeMirrorInstance = this.getCodeMirrorInstance();`
`@@ -44,7 +47,7 @@ var CodeMirror = React.createClass({`
`44`	`47`	`this.codeMirror.toTextArea();`
`45`	`48`	`}`
`46`	`49`	`},`
`47`		`- componentWillReceiveProps: debounce(function (nextProps) {`
	`50`	`+ componentWillReceiveProps: function componentWillReceiveProps(nextProps) {`
`48`	`51`	`if (this.codeMirror && nextProps.value !== undefined && this.codeMirror.getValue() !== nextProps.value) {`
`49`	`52`	`this.codeMirror.setValue(nextProps.value);`
`50`	`53`	`}`
`@@ -55,7 +58,7 @@ var CodeMirror = React.createClass({`
`55`	`58`	`}`
`56`	`59`	`}`
`57`	`60`	`}`
`58`		`- }, 0),`
	`61`	`+ },`
`59`	`62`	`getCodeMirror: function getCodeMirror() {`
`60`	`63`	`return this.codeMirror;`
`61`	`64`	`},`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,9 @@ const CodeMirror = React.createClass({`
`24`	`24`	`isFocused: false,`
`25`	`25`	`};`
`26`	`26`	`},`
	`27`	`+ componentWillMount () {`
	`28`	`+ this.componentWillReceiveProps = debounce(this.componentWillReceiveProps, 0);`
	`29`	`+ },`
`27`	`30`	`componentDidMount () {`
`28`	`31`	`const textareaNode = findDOMNode(this.refs.textarea);`
`29`	`32`	`const codeMirrorInstance = this.getCodeMirrorInstance();`
`@@ -40,7 +43,7 @@ const CodeMirror = React.createClass({`
`40`	`43`	`this.codeMirror.toTextArea();`
`41`	`44`	`}`
`42`	`45`	`},`
`43`		`- componentWillReceiveProps: debounce(function (nextProps) {`
	`46`	`+ componentWillReceiveProps: function (nextProps) {`
`44`	`47`	`if (this.codeMirror && nextProps.value !== undefined && this.codeMirror.getValue() !== nextProps.value) {`
`45`	`48`	`this.codeMirror.setValue(nextProps.value);`
`46`	`49`	`}`
`@@ -51,7 +54,7 @@ const CodeMirror = React.createClass({`
`51`	`54`	`}`
`52`	`55`	`}`
`53`	`56`	`}`
`54`		`- }, 0),`
	`57`	`+ },`
`55`	`58`	`getCodeMirror () {`
`56`	`59`	`return this.codeMirror;`
`57`	`60`	`},`