Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/grumpy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: lalaithion/grumpy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 0 files changed
  • 1 contributor

Commits on Jan 5, 2017

  1. Added math library

    @lalaithion
    lalaithion committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    eaa4fd6 View commit details
    Browse the repository at this point in the history

  2. Moved a helper function inside main function

    @lalaithion
    lalaithion committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    2f87a70 View commit details
    Browse the repository at this point in the history

  3. Arguments now wrapped in call to float 

    other changes:
unnecessary elses removed
double newline after top level definitions added
    @lalaithion
    lalaithion committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    232087e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2017

  1. factorial has better error messages and accepts 0 

    other style fixes changed as well
    @lalaithion
    lalaithion committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    737dad4 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2017

  1. Added Tests for Math Library

    @lalaithion
    lalaithion committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    225f020 View commit details
    Browse the repository at this point in the history

  2. Added tests for domain errors in factorial()

    @lalaithion
    lalaithion committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    169141b View commit details
    Browse the repository at this point in the history

  3. Made factorial() more performant 

    It also makes better checks for the input.
Part of factorial() taken from PyPy's version.
    @lalaithion
    lalaithion committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    a010362 View commit details
    Browse the repository at this point in the history

  4. Removed NOTE comment that had been resolved

    @lalaithion
    lalaithion committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    8afc1d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. Removed PyPy factorial() implementation 

    Added liscenses to top of files
    @lalaithion
    lalaithion committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    2f8e076 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2017

  1. Merge https://github.com/google/grumpy

    @lalaithion
    lalaithion committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    2cde6d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2017

  1. Merge branch 'master' of git://github.com/google/grumpy

    @lalaithion
    lalaithion committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    33fde3d View commit details
    Browse the repository at this point in the history
Loading