Forbid connection making a loop on a single node (paceholder#111)

Author: paceholder

src/Node.cpp

@@ -86,7 +86,6 @@ id() const
 void
 Node::
 reactToPossibleConnection(PortType reactingPortType,
-
                           NodeDataType reactingDataType,
                           QPointF const &scenePoint)
 {

src/NodeConnectionInteraction.cpp

@@ -33,11 +33,18 @@ canConnect(PortIndex &portIndex, bool& typeConversionNeeded, std::unique_ptr<Nod
 
   PortType requiredPort = connectionRequiredPort();
 
+
   if (requiredPort == PortType::None)
   {
     return false;
   }
 
+  // 1.5) Forbid connecting the node to itself
+  Node* node = _connection->getNode(oppositePort(requiredPort));
+
+  if (node == _node)
+    return false;
+
   // 2) connection point is on top of the node port
 
   QPointF connectionPoint = connectionEndScenePosition(requiredPort);
@@ -89,7 +96,7 @@ tryConnect() const
   {
     return false;
   }
-  
+
   /// 1.5) If the connection is possible but a type conversion is needed, add a converter node to the scene, and connect it properly
   if (typeConversionNeeded)
   {

src/NodeConnectionInteraction.hpp

@@ -59,13 +59,13 @@ class NodeConnectionInteraction
                                          QPointF const &p) const;
 
   bool nodePortIsEmpty(PortType portType, PortIndex portIndex) const;
-  
+
 private:
 
   Node* _node;
 
   Connection* _connection;
-  
+
   FlowScene* _scene;
 };
-}
+}