Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: helm/helm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: damoxc/helm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 6 files changed
  • 2 contributors

Commits on Apr 11, 2018

  1. Update helm template -x to support children chart manifests in more c…

    …ases
    
    The previous code validated the manifests exist within the file system,
    which only works when a chart is unpacked, meaning children charts
    stored as tgz's in the parent chart's `charts/` directory don't exist as
    individual files in the filesystem, causing validation to file.
    
    Instead, we validate against the paths within the chart itself rather
    than the filesystem, handling both chart.tgz's and charts that are
    unpacked as directories in the chart/ directory.
    Chance Zibolski committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    62f8532 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7e7170 View commit details
    Browse the repository at this point in the history
  3. test helm template -x against subcharts stored as tgz's

    Chance Zibolski committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    62a58e8 View commit details
    Browse the repository at this point in the history
  4. Disambigutate chartPaths variables in helm template tests

    Chance Zibolski committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    ced20f6 View commit details
    Browse the repository at this point in the history
  5. Correctly use subtests in helm template tests

    The testing.T in the subtest wasn't being used, so subtests were
    effectively not being used. Additionally, in case subtests run in
    parallel, we assign tt := tt to fix closure captures on range variables,
    since the variables produced by a range are re-used between iterations.
    Chance Zibolski committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    b9adc35 View commit details
    Browse the repository at this point in the history
  6. test helm template -x with non-existent manifest

    Chance Zibolski committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    fb1dd48 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Merge pull request #3877 from chancez/enhance_helm_template_handling

    Update helm template -x to support children chart manifests in more cases
    SlickNik authored Apr 12, 2018
    Configuration menu
    Copy the full SHA
    30f236b View commit details
    Browse the repository at this point in the history
Loading