Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/breakpad
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: google/breakpad
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: chrome_90
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 16, 2021

  1. Strip LLVM-generated symbol suffixes when demangling Windows symbols 

    LLVM, especially in ThinLTO builds, sometimes puts a suffix on symbols
to give them a unique name. For example:

   ?foo@@yaxxz$5520c83448162c04f2b239db4b5a2c61
   ?foo@@YAXXZ.llvm.1304071520971994875

Strip such suffixes in order to demangle the names.

Bug: chromium:1179132
Change-Id: Ibc8da0c605b95c6b9fc51802a56b89f6e7cfb7e1
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2739612
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
(cherry picked from commit d6a6f52)
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2763248
    @zmodem @markmentovai
    zmodem authored and markmentovai committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b324760 View commit details
    Browse the repository at this point in the history
Loading